Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: evaluates option not working well #83

Merged
merged 4 commits into from
Feb 7, 2025
Merged

fix: evaluates option not working well #83

merged 4 commits into from
Feb 7, 2025

Conversation

righ
Copy link
Member

@righ righ commented Feb 6, 2025

Description

The table.getMatrixFlatten method is supposed to return unevaluated formulas when the evaluates option is set to false. However, due to an issue, it currently returns internal IDs instead of the formulas. This will be fixed shortly.

refs #82

Type of Change

  • Bug fix
  • Improvement
  • New feature
  • Breaking change
  • Reword
  • The other

Impact Area

  • Table methods

How Has This Been Tested?

  • Visual operation check - yarn storybook
  • Test - yarn test
  • Lint - yarn eslint
    • Format the code in advance with prettier. - yarn prettier

Additional Context

I’ve also upgraded the Node version and fixed the E2E tests. refs #84

@righ righ merged commit 77df182 into master Feb 7, 2025
3 checks passed
@righ righ deleted the fix/issue-82 branch February 7, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant